Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] add conv support #8688

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[SYCL] add conv support #8688

merged 1 commit into from
Jul 29, 2024

Conversation

airMeng
Copy link
Collaborator

@airMeng airMeng commented Jul 25, 2024 •
edited
Loading

To support SYCL backend for stablediffusion.cpp leejet/stable-diffusion.cpp#308
This is a temporary solution, we will introduce OneDNN for convolution performance

@airMeng airMeng added the SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language label Jul 25, 2024
@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Jul 25, 2024
@airMeng
Copy link
Collaborator Author

airMeng commented Jul 26, 2024

@ggerganov I wonder for these pure operators, shall I raise the PR to GGML repo directly or to llama.cpp? which one is prefered?

zhentaoyu
zhentaoyu approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@zhentaoyu zhentaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ggerganov
ggerganov approved these changes Jul 26, 2024
View reviewed changes
Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall I raise the PR to GGML repo directly or to llama.cpp? which one is prefered?

It's fine to make the PR here - there is more activity in llama.cpp. Will sync the changes upstream later today or tomorrow

@airMeng airMeng merged commit 0832de7 into master Jul 29, 2024
54 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Aug 2, 2024
@airMeng
[SYCL] add conv support (ggerganov#8688)
faaebf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhentaoyu zhentaoyu zhentaoyu approved these changes

@ggerganov ggerganov ggerganov approved these changes

@joeatodd joeatodd Awaiting requested review from joeatodd

@NeoZhangJianyu NeoZhangJianyu Awaiting requested review from NeoZhangJianyu

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@airMeng @ggerganov @zhentaoyu