docker : Install curl in runtime layer in llama-server.Dockerfile #8693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
Closed
|
Should we do the same for all
|
ngxson
changed the title
|
curl is already installed in the others. In this one, a mistake was made where it is being installed in the first layer but is not present in the final layer. |
mofosyne
added
the
Review Complexity : Low
ngxson
approved these changes
Aug 4, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'curl' needs to be installed in the
runtimelayer in order for a docker health check to work in the basic server image