cuda : fix dmmv cols requirement to 2*GGML_CUDA_DMMV_X #8800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebtenzzre
reviewed
Jul 31, 2024
There was a problem hiding this comment.
I can't reproduce #8798 with this change applied. I think it would be nice if we also added a regression test to test-backend-ops, since you could get it to fail that way.
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jul 31, 2024
Fix provided by Slaren
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jul 31, 2024
Fix provided by Slaren
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jul 31, 2024
Fix provided by Slaren
JohannesGaessler
approved these changes
Aug 1, 2024
mofosyne
added
bugfix
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Aug 2, 2024
* cuda : fix dmmv cols requirement to 2*GGML_CUDA_DMMV_X * update asserts * only use dmmv for supported types * add test
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May fix #8798