[CANN] Fix buffer_num and runtime speed slowly error #8865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
reviewed
Aug 5, 2024
Comment on lines
1670
to
1672
| // TODO: fix me | ||
| // Current groupsize should not be greater than k-1 in | ||
| // aclnnWeightQuantBatchMatmulV2GetWorkspaceSize(). |
There was a problem hiding this comment.
Is this comment still relevant after removing the respective code block?
There was a problem hiding this comment.
Error about this comment has not been resolved yet, keep TODO to resolve later.
github-actions
bot
added
the
ggml
mofosyne
added
Review Complexity : Low
ggerganov
previously approved these changes
Aug 5, 2024
hipudding
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the fellowing error:
BUFFER_NUM >1, and which length need be1.if in switchcauses the inference speed to decrease