ggml : remove K_QUANTS_PER_ITERATION macro #9034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Nvidia GPU
|
The docs (which are not updated in this PR, by the way) claim that "setting this value to 1 can improve performance for slow GPUs". Is this no longer true? (It doesn't help that no mention is made which GPUs these are supposed to be, as in, class or generation). |
ggerganov
force-pushed
the
gg/remove-k-quants-per-iter
branch
from
943f851 to
ccb4518
Compare
github-actions
bot
added
the
documentation
|
Not sure, I just haven't noticed this compile option to be used so I think it is not worth keeping the extra code paths from maintenance PoV |
|
Eh, I suppose it's easy enough to restore if someone who does see performance gains from it complains. It would also be interesting to know who (or rather what) benefits from tweaking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aways use a value of 2