Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix library is missing during dynamic compiling #9070

Closed
wants to merge 1 commit into from
Closed

ci: fix library is missing during dynamic compiling #9070

wants to merge 1 commit into from

Conversation

Aisuko
Copy link
Contributor

@Aisuko Aisuko commented Aug 18, 2024 •
edited
Loading

Fix the issue llama.cpp binaries are compiled dynamically and the library is missing on Intel image.

@github-actions github-actions bot added the devops improvements to build systems and github actions label Aug 18, 2024
@Aisuko Aisuko changed the title fix library is missing during dynamic compiling ci:fix library is missing during dynamic compiling Aug 18, 2024
@Aisuko Aisuko changed the title ci:fix library is missing during dynamic compiling ci: fix library is missing during dynamic compiling Aug 18, 2024
ggerganov
ggerganov reviewed Aug 19, 2024
View reviewed changes
Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently noticed this issue too. We should fix the shared libs build instead of circumventing it like this

@Aisuko
Copy link
Contributor Author

Aisuko commented Aug 19, 2024

Got it. I close this.

@Aisuko Aisuko closed this Aug 19, 2024
@Aisuko Aisuko deleted the fix/dockerbuild branch August 19, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov left review comments

Assignees
No one assigned
Labels
devops improvements to build systems and github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aisuko @ggerganov