Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llama : fix typo in xcda_array_view comment [no ci] #9132

Merged
merged 1 commit into from
Aug 31, 2024
Merged

llama : fix typo in xcda_array_view comment [no ci] #9132

merged 1 commit into from
Aug 31, 2024

Conversation

danbev
Copy link
Collaborator

@danbev danbev commented Aug 22, 2024

@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Aug 30, 2024
mofosyne
mofosyne approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@mofosyne mofosyne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if you could spot other typos or improvements you can make around that area, always bit iffy of single typo commit fixes. But approved anyway and defer to other's judgement.

@danbev
Copy link
Collaborator Author

danbev commented Aug 30, 2024

I wonder if you could spot other typos or improvements you can make around that area, always bit iffy of single typo commit fixes.

I just came across this when going through the unigram tokenizer. I'm about to look closer at the workpiece tokenizer and if I find anything there I'll update this.
But I'm also happy to close this if it is annoying. It's just that I forget these if I don't "fix" them straight away.

@ggerganov ggerganov merged commit 49271ef into ggerganov:master Aug 31, 2024
52 checks passed
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
@danbev @dsx1986
llama : fix typo in xcda_array_view comment [no ci] (ggerganov#9132)
735a5b6
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
@danbev @arthw
llama : fix typo in xcda_array_view comment [no ci] (ggerganov#9132)
e95d799
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
@danbev @arthw
llama : fix typo in xcda_array_view comment [no ci] (ggerganov#9132)
d93995a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofosyne mofosyne mofosyne approved these changes

Assignees
No one assigned
Labels
Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danbev @mofosyne @ggerganov