Fix nix CUDA build: replace deprecated autoAddOpenGLRunpathHook #9137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
nix
|
Nix builds with CUDA enabled are still broken without this, bumping. |
mofosyne
added
the
Review Complexity : Low
|
will probably be superseded by #9220 |
|
Oh I didn't notice this one |
SomeoneSerge
approved these changes
Aug 30, 2024
|
Actually, can you reword the commit as per https://github.com/ggerganov/llama.cpp/blob/master/CONTRIBUTING.md#pull-requests-for-collaborators? The part before |
The CUDA nix build broke when we updated nixpkgs in 8cd1bcf. As far as I can tell all that happened is cudaPackages.autoAddOpenGLRunpathHook got moved to pkgs.autoAddDriverRunpath. This commit fixes it.
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CUDA nix build broke when we updated nixpkgs in 8cd1bcf. As far as I can tell all that happened is cudaPackages.autoAddOpenGLRunpathHook got moved to pkgs.autoAddDriverRunpath. This commit fixes it.