llama : disambiguate API #9270
Closed
llama : disambiguate API #9270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggml-ci
slaren
reviewed
Sep 2, 2024
include/llama.h
Outdated
Comment on lines
474
to
477
| // DEPRECATED: use the API above | ||
| //LLAMA_API enum llama_pooling_type llama_pooling_type(const struct llama_context * ctx); | ||
| //LLAMA_API enum llama_vocab_type llama_vocab_type (const struct llama_model * model); | ||
| //LLAMA_API enum llama_rope_type llama_rope_type (const struct llama_model * model); |
There was a problem hiding this comment.
Deprecated means that the functions are still available and will be removed soon. This is a breaking API change.
ggerganov
added
the
breaking change
|
This change breaks the naming convention, which is not great because the API harder to use. However renaming every getter function would break every application, which is also not very good. This may be a case where the solution is worse than the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9262
Rename functions
llama_xxx_typetollama_get_xxx_type