GGML_TARGET_DEFINES-NOTFOUND
fix for builds without GGML_CDEF_PUBLIC
#9338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some builds I had an error with the message
<command-line>: error: ISO C++11 requires whitespace after the macro name [-Werror]
.After research it turned out that the reason is that
llama-config.cmake
containsAs you can see set contains
GGML_TARGET_DEFINES-NOTFOUND
. The reason for this was that I was building llama.cpp with a completely default CPU backend (without any bias and so on). I propose a fix that checks that the properties are set.