llama : refactor samplers internal implementation #9370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
reviewed
Sep 8, 2024
src/llama-sampling.cpp
Outdated
Comment on lines
398
to
402
| static void llama_sampler_dist_reset(struct llama_sampler * smpl) { | ||
| // is this correct? | ||
| auto * ctx = (llama_sampler_dist *) smpl->ctx; | ||
| ctx->rng = std::mt19937(ctx->seed); | ||
| } |
There was a problem hiding this comment.
Yes, I've missed to implement it.
ggerganov
approved these changes
Sep 8, 2024
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_implfunctionsI plan to do more changes, but it may be worth merging this now to fix the penalties sampler.