-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sycl : update support conditions #9394
sycl : update support conditions #9394
Conversation
Signed-off-by: Alberto Cabrera <alberto.cabrera@codeplay.com>
@Alcpz Some UT cases are updated for CUDA improvement, so the new/updated cases are not passed with SYCL backend. If skip such UT cases, we won't know what's the gap. Fault UT cases feedback the issues. In previous months, the UT pass rate is high (96%).
In latest commit: 2a358fb
We can see the new test cases are added:
There is no reason SYCL can't support them. It's same for other fault cases. So, I suggest to keep the original supports_op() function. |
@NeoZhangJianyu Thanks for the quick review. That said, I don't want to imply that we don't plan to support this in the future, so I will add a TODO to address it at a later time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Alcpz Thank you! |
* sycl : update support condition to im2col Signed-off-by: Alberto Cabrera <alberto.cabrera@codeplay.com> * Added TODO to remind supporting FP32 im2col --------- Signed-off-by: Alberto Cabrera <alberto.cabrera@codeplay.com>
* sycl : update support condition to im2col Signed-off-by: Alberto Cabrera <alberto.cabrera@codeplay.com> * Added TODO to remind supporting FP32 im2col --------- Signed-off-by: Alberto Cabrera <alberto.cabrera@codeplay.com>
* sycl : update support condition to im2col Signed-off-by: Alberto Cabrera <alberto.cabrera@codeplay.com> * Added TODO to remind supporting FP32 im2col --------- Signed-off-by: Alberto Cabrera <alberto.cabrera@codeplay.com>
Updates SYCL supported OPs checks to be in line with the updates introduced in previous PRs, as test-backend-ops is currently failing due to unsupported datatypes in CONT and IM2COL.