llama : move random seed generation to the samplers #9398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
added
the
breaking change
ggerganov
approved these changes
Sep 10, 2024
examples/server/server.cpp
Outdated
Comment on lines
1269
to
1270
| // replace seed instead? | ||
| {"seed_cur", slot.smpl ? gpt_sampler_get_seed(slot.smpl) : 0}, |
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
* llama_sampler_penalties : clamp penalty_last_n to zero
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
* llama_sampler_penalties : clamp penalty_last_n to zero
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
* llama_sampler_penalties : clamp penalty_last_n to zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing a sampler with
LLAMA_DEFAULT_SEEDcauses it to generate its own seeds. When the sampler is reset, a new seed is generated.Note that
LLAMA_DEFAULT_SEEDbeing0xFFFFFFFFresults in rather unreadable number when printed in decimal. Might be easier to understand ifLLAMA_DEFAULT_SEEDis changed to zero.This should fix the server generating always the same response.