Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

naming : normalize the name of callback-related identifiers #9405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

naming : normalize the name of callback-related identifiers #9405

wants to merge 1 commit into from

Conversation

ggerganov
Copy link
Owner

@ggerganov ggerganov commented Sep 10, 2024 •
edited
Loading

Renames identifiers into the following convention:

foo_callback cb_foo;
void *       cb_foo_ctx;

Or when the callback context is unambiguous, simply to:

void foo_set(foo_callback cb, void * cb_ctx);

Request for comments: is this change worth it?

@github-actions github-actions bot added testing Everything test related examples ggml changes relating to the ggml tensor library for machine learning Apple Metal https://en.wikipedia.org/wiki/Metal_(API) labels Sep 10, 2024
ggerganov
ggerganov commented Sep 10, 2024
View reviewed changes
include/llama.h
bool embeddings; // if true, extract embeddings (together with logits)
bool offload_kqv; // offload the KQV ops (including the KV cache) to GPU
bool flash_attn; // enable flash attention [EXPERIMENTAL]
bool no_perf; // disable performance timings
Copy link
Owner Author

@ggerganov ggerganov Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks libllama and libggml API because of parameter reordering and renaming

@ggerganov ggerganov changed the title naming : normalize the name of callback-related symbols naming : normalize the name of callback-related identifiers Sep 10, 2024
Base automatically changed from gg/llama-perf to master September 13, 2024 06:53
@ggerganov ggerganov added the breaking change Changes that break ABIs, APIs, file formats, or other forms of backwards compatibility. label Sep 16, 2024
@ggerganov ggerganov marked this pull request as ready for review September 16, 2024 06:12
@ggerganov ggerganov mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Apple Metal https://en.wikipedia.org/wiki/Metal_(API) breaking change Changes that break ABIs, APIs, file formats, or other forms of backwards compatibility. examples ggml changes relating to the ggml tensor library for machine learning testing Everything test related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ggerganov