Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the order of linking libraries for llama-quantize #9450

Merged

Conversation

Xarbirus
Copy link
Contributor

While working on this pr, I discovered that when building with -DGGML_STATIC=ON flag, the next error occurs:

[99/105] Linking CXX executable bin/llama-quantize
ld: warning: ignoring duplicate libraries: 'src/libllama.a'

In this request the library linking order has been corrected to get rid of the error. This order also corresponds to all other examples.

@ggerganov ggerganov merged commit ff76e18 into ggerganov:master Sep 12, 2024
52 checks passed
@Xarbirus Xarbirus deleted the ignoring_duplicate_libraries_fix branch September 12, 2024 11:59
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants