Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add env variable for parallel #9513

Merged
merged 2 commits into from
Sep 17, 2024
Merged

add env variable for parallel #9513

merged 2 commits into from
Sep 17, 2024

Conversation

bertwagner
Copy link
Contributor

The LLaMA.cpp HTTP Server README mentions using environment variable LLAMA_ARG_N_PARALLEL for setting the value of --parallel. This environment variable is missing from common/arg.cpp and this PR adds it in.

@VJHack
Copy link
Contributor

VJHack commented Sep 17, 2024 •
edited
Loading

Nit: I would suggest that you just add (env: LLAMA_ARG_N_PARALLEL) to the docs here for clarity.

ggerganov
ggerganov approved these changes Sep 17, 2024
View reviewed changes
Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge after the updated help message as suggested

@bertwagner
Copy link
Contributor Author

Thanks for the suggestion @VJHack . @ggerganov the README is now updated and ready to merge, thank you.

@ggerganov ggerganov merged commit 8b836ae into ggerganov:master Sep 17, 2024
52 checks passed
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
@bertwagner @dsx1986
arg : add env variable for parallel (ggerganov#9513)
4cec4c7 
* add env variable for parallel

* Update README.md with env:  LLAMA_ARG_N_PARALLEL
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
@bertwagner @arthw
arg : add env variable for parallel (ggerganov#9513)
77412da 
* add env variable for parallel

* Update README.md with env:  LLAMA_ARG_N_PARALLEL
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
@bertwagner @arthw
arg : add env variable for parallel (ggerganov#9513)
09549b7 
* add env variable for parallel

* Update README.md with env:  LLAMA_ARG_N_PARALLEL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
examples server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bertwagner @VJHack @ggerganov