Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llama-bench: correct argument parsing error message #9524

Merged
merged 1 commit into from
Sep 17, 2024
Merged

llama-bench: correct argument parsing error message #9524

merged 1 commit into from
Sep 17, 2024

Conversation

Xarbirus
Copy link
Contributor

@Xarbirus Xarbirus commented Sep 17, 2024 •
edited
Loading

Without this change, the error message would indicate an incorrect flag because break would break the inner loop but not the outer one.

@slaren slaren merged commit 7be099f into ggerganov:master Sep 17, 2024
50 of 51 checks passed
@Xarbirus Xarbirus deleted the llama-bench-arg-parsing branch September 23, 2024 16:54
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
@Xarbirus @dsx1986
llama-bench: correct argument parsing error message (ggerganov#9524)
1ddb77d
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
@Xarbirus @arthw
llama-bench: correct argument parsing error message (ggerganov#9524)
0fbf6bf
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
@Xarbirus @arthw
llama-bench: correct argument parsing error message (ggerganov#9524)
a445eee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaren slaren slaren approved these changes

Assignees
No one assigned
Labels
examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xarbirus @slaren