Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: corrected encoding when getting chat template (#11866) #11907

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

MoonRide303
Copy link
Contributor

JSON files must be UTF-8 encoded, see 8.1 in RFC 8259.

@github-actions github-actions bot added script Script related python python script changes labels Feb 16, 2025
@MoonRide303
Copy link
Contributor Author

@ochafik This fixes problem with existing script (#11866 (comment)).

I am also wondering if I should add this variant of mine #11866 (comment), which allows saving UTF-8 encoded templates (sys.stdout used in current script produces UTF-16 output - at least on Windows).

@ngxson ngxson requested a review from ochafik February 16, 2025 15:06
Copy link
Collaborator

@ochafik ochafik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ngxson ngxson merged commit 5137da7 into ggml-org:master Feb 18, 2025
4 checks passed
@MoonRide303 MoonRide303 deleted the fix-get-chat-template-encoding branch February 18, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python python script changes script Script related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants