Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data use and access Guideline #49

Merged
merged 17 commits into from
Jan 29, 2025
Merged

Add data use and access Guideline #49

merged 17 commits into from
Jan 29, 2025

Conversation

eufjan
Copy link
Member

@eufjan eufjan commented Jan 27, 2025

Based on discussion within this document, this adds instructions to data submitters how to deal with DARs.
It does not perfectly fit under "User Stories" but should be moved to "Resources" once the new structure is implemented.

@eufjan
Copy link
Member Author

eufjan commented Jan 27, 2025

Copy link
Contributor

@SimonParkerDKFZ SimonParkerDKFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates Jan.

Have added some comments.

@eufjan
Copy link
Member Author

eufjan commented Jan 27, 2025

Thanks for the updates Jan.

Have added some comments.

Great, thanks. Committed the changes as proposed, could you review again?

BTW: while reviewing, you can directly suggest the changes in the text, see
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request
image

Copy link
Contributor

@SimonParkerDKFZ SimonParkerDKFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have made some suggestions for potential changes (with in-line suggestions!)

@eufjan
Copy link
Member Author

eufjan commented Jan 29, 2025

Have made some suggestions for potential changes (with in-line suggestions!)

Awesome, thanks. All committed now. Can you check again and approve the request?

Copy link
Contributor

@SimonParkerDKFZ SimonParkerDKFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now - we can discuss the links issue

@eufjan eufjan merged commit ac323d5 into main Jan 29, 2025
1 check passed
@eufjan eufjan deleted the dua-guideline branch January 29, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants