Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated dpc information #50

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Updated dpc information #50

merged 7 commits into from
Jan 29, 2025

Conversation

SimonParkerDKFZ
Copy link
Contributor

@SimonParkerDKFZ SimonParkerDKFZ commented Jan 29, 2025 •
edited
Loading

I have made changes based on feedback from Outreach.

A checklist has been added to the DPC information page, and they suggested the inclusion of an image to break up the text.

@SimonParkerDKFZ SimonParkerDKFZ self-assigned this Jan 29, 2025
eufjan
eufjan requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@eufjan eufjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I change some formatting and added a suggestion to explain the checklist. looks good.

user_docs/user_stories/submission/dpc_preparation.md Outdated Show resolved Hide resolved
SimonParkerDKFZ
SimonParkerDKFZ commented Jan 29, 2025
View reviewed changes
Copy link
Contributor Author

@SimonParkerDKFZ SimonParkerDKFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

SimonParkerDKFZ
SimonParkerDKFZ commented Jan 29, 2025
View reviewed changes
Copy link
Contributor Author

@SimonParkerDKFZ SimonParkerDKFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why but it is still saying I need to approve your request for changes...

SimonParkerDKFZ
SimonParkerDKFZ commented Jan 29, 2025
View reviewed changes
Copy link
Contributor Author

@SimonParkerDKFZ SimonParkerDKFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

SimonParkerDKFZ
SimonParkerDKFZ commented Jan 29, 2025
View reviewed changes
Copy link
Contributor Author

@SimonParkerDKFZ SimonParkerDKFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@SimonParkerDKFZ SimonParkerDKFZ merged commit 4c31785 into main Jan 29, 2025
1 check passed
@SimonParkerDKFZ SimonParkerDKFZ deleted the Updated-DPC-information branch January 29, 2025 15:05
@eufjan
Copy link
Member

eufjan commented Jan 29, 2025

Not sure why but it is still saying I need to approve your request for changes...

Somehow I needed to approve my own changes 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eufjan eufjan eufjan approved these changes

Assignees

@SimonParkerDKFZ SimonParkerDKFZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonParkerDKFZ @eufjan