Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: validate issue title on create and update #1070

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seia-soto
Copy link
Member

@seia-soto seia-soto commented Jan 8, 2025

This adds a CI that validates and labels an issue if its title is not properly formatted.

Requirements:

  • Label called 'checks/invalid-issue-title'

See seia-soto/broken-page-reports-issue-title-validation-test#1 (comment) for sample output.

@seia-soto seia-soto requested a review from chrmod January 8, 2025 12:34
@seia-soto seia-soto self-assigned this Jan 8, 2025
env:
NAME: ${{ github.event.issue.title }}
run: |
deno install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't jdx/mise-action@v2 do it already?

Copy link
Member Author

@seia-soto seia-soto Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done separately to filter out deno's stdout like "download npm:tldts"

.github/workflows/validate-issue-title.yaml Show resolved Hide resolved
run: |
deno install
{
echo 'VALERR<<EOF'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets rename VALERR to something easier to understand :)

.github/workflows/validate-issue-title.yaml Outdated Show resolved Hide resolved
@seia-soto seia-soto changed the title feat(ci): validate issue title on create and update ci: validate issue title on create and update Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants