-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support $redirect
in DNR
#1750
Support $redirect
in DNR
#1750
Conversation
}, | ||
{ | ||
"resources": [ | ||
"rule_resources/statics/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be merged with the list above as it is meant to be used on all_frames and with <all_urls>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Philipp Claßen <[email protected]>
@seia-soto please provide test cases for @GRadziejewski |
Generating WAR list is simpler than introducing the glob pattern to copy assets.
Hi @GRadziejewski , Here's a testing instruction for Ghostery Browser Extension. Before we start, the purpose of refs https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#redirect I'm going to use the following website to test if we can make sure if
using the following filter: ||iana.org/_img/2022/iana-logo-header.svg$redirect=32x32.png
Unlike the general request blocking, you always should get the response code of |
Converting to draft: We have add a support for custom filters. |
Pending update from ghostery/urlfilter2dnr#16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The redirect locations don't match DNR rules...
For example, the DoubleClick redirect shows me in the console:
chrome-extension://jccobfekniccmgppgbkonmdmdldhhgjc/rule_resources/redirects/googletagservices-gpt.js
But the real location is extension-manifest-v3/dist/rule_resources/redirects/googletagservices_gpt.js
(by the transfer in the build step).
The -
from DNR rule is _
in the file system.
The redirect resource urls were fixed on the ruleset generation side. |
fixes #1714
This PR extracts resources from the
ads
engine binary on build time and registers into manifest.TODO