fix: event update http 400 due to description #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/giantswarm/giantswarm/issues/31517
Summary
Fix a long standing and confusing issue with "half synced" outOfOffice events (time-offs created in Personio but unable to update Google Calendar and make the permanent connection).
The problem was triggered when Google Calendar stopping to accept PUT requets with events containing a
descriptionfield for events witheventTypeset to anything but'default'.This PR also improves the
unsynchelper functions, even though a completely custom unsync function is required to cleanup the mess (disjoint events in Personio) created by this bug.