Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to README file in dataset page #2155

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

luistoptal
Copy link
Collaborator

Pull request for issue: #1289

Adds link to the readme file in the files tab of the dataset page

image

How to test?

How have functionalities been implemented?

  • It is unclear to me how to calculate the file location because I am not sure how to determine the correct range mentioned in make readme file the first in the file list #1289 so instead I parse the files and search for the file based on $file['type'] === 'Readme' and use the first match as readme file to link to. So this assumes that readme always has $file['type'] === 'Readme' and that there is one single readme

The heuristic could be easily changed to accomodate other requirements

Any issues with implementation?

Unknown how to determine the correct range for the url so I used a different logic

Any changes to automated tests?

Added one acceptance test, which is pending to be "ok" when I can run tests again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant