Add link to README file in dataset page #2155
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #1289
Adds link to the readme file in the files tab of the dataset page
How to test?
How have functionalities been implemented?
$file['type'] === 'Readme'
and use the first match as readme file to link to. So this assumes that readme always has$file['type'] === 'Readme'
and that there is one single readmeThe heuristic could be easily changed to accomodate other requirements
Any issues with implementation?
Unknown how to determine the correct range for the url so I used a different logic
Any changes to automated tests?
Added one acceptance test, which is pending to be "ok" when I can run tests again