-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataset feed to homepage #2167
Draft
luistoptal
wants to merge
20
commits into
gigascience:develop
Choose a base branch
from
luistoptal:new-feature/199-homepage-dataset-carousel
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add dataset feed to homepage #2167
luistoptal
wants to merge
20
commits into
gigascience:develop
from
luistoptal:new-feature/199-homepage-dataset-carousel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luistoptal
changed the title
New feature/199 homepage dataset carousel
Add dataset feed to homepage
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #199
IMPORTANT: this is a follow up to PR #2078, I suggest reviewing #2078 and this PR in combination as this one includes refactor to the changes in #2078
How to test?
In home page http://gigadb.gigasciencejournal.com/ you should see a responsive carousel with datasets
How have functionalities been implemented?
protected/views/shared/_carousel_slider.php
SiteController
a dataset search is performed and the search result passed to the view to be able to render a list of datasets as a carouselprotected/views/site/datasets_carousel.php
Any issues with implementation?
protected/components/FormattedDatasetMainSection.php
, in this PR I am directly accessing the dataset values but I do not know if I should use these utilities instead, for example, to get the dataset title i do:But I think that it might be possible to alternatively do something like:
Any changes to automated tests?
--