Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'hidden lifetime parameters in types are deprecated' #713

Merged
merged 1 commit into from
May 4, 2024

Conversation

Enselic
Copy link
Contributor

@Enselic Enselic commented May 2, 2024

I am messing around with Rust's standard library and gimli. In my particular setup, Rust's build system tries to build gimli in a way that can be simulated like this:

cargo rustc --  -Wrust_2018_idioms -Wunused_lifetimes -Dwarnings

When build that way, the master branch fails with a bunch of errors like this:

error: hidden lifetime parameters in types are deprecated

This PR fixes that.

Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not convinced this is useful for parameters (which is the bulk of this PR), but I guess that ship has sailed.

Since you've gone to the effort of changing this, I assume that you want this to continue to work, so

//#![warn(elided_lifetimes_in_paths)]
should be changed to help check that.

Also it appears that other targets such as tests need fixing still.

@Enselic
Copy link
Contributor Author

Enselic commented May 3, 2024

Thanks for review. I have now enabled it as a warning and also updated tests (so that there is no warning emitted when running cargo test).

@philipc philipc merged commit b921aa3 into gimli-rs:master May 4, 2024
20 checks passed
@Enselic Enselic deleted the lifetime branch May 4, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants