Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add build tag #3214

Closed
wants to merge 3 commits into from
Closed

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Jun 28, 2022

jsoniter tag run unit test error:

=== RUN   TestContextRenderIndentedJSON
    context_test.go:757: 
        	Error Trace:	context_test.go:757
        	Error:      	Not equal: 
        	            	expected: "{\n    \"bar\": \"foo\",\n    \"foo\": \"bar\",\n    \"nested\": {\n        \"foo\": \"bar\"\n    }\n}"
        	            	actual  : "{\n    \"bar\": \"foo\",\n    \"foo\": \"bar\",\n    \"nested\": {\n    \"foo\": \"bar\"\n}\n}"
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -4,4 +4,4 @@
        	            	     "nested": {
        	            	-        "foo": "bar"
        	            	-    }
        	            	+    "foo": "bar"
        	            	 }
        	            	+}
        	Test:       	TestContextRenderIndentedJSON

details: json-iterator/go#564 and json-iterator/go#229

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #3214 (b7173f4) into master (92dd245) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3214   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files          43       43           
  Lines        3148     3148           
=======================================
  Hits         3087     3087           
  Misses         48       48           
  Partials       13       13           
Flag Coverage Δ
go-1.15 98.06% <ø> (ø)
go-1.16 98.03% <ø> (ø)
go-1.17 97.96% <ø> (ø)
go-1.18 97.96% <ø> (ø)
go_json 98.04% <ø> (?)
macos-latest 98.06% <ø> (ø)
nomsgpack 98.03% <ø> (ø)
ubuntu-latest 98.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92dd245...b7173f4. Read the comment docs.

@thinkerou thinkerou requested a review from appleboy June 28, 2022 09:54
@thinkerou thinkerou added this to the v1.9 milestone Jun 28, 2022
@thinkerou thinkerou closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant