Add specific communicator for neighborhood communication (Again) #1780
Conversation
ginkgo-bot
added
reg:build
| @@ -0,0 +1,37 @@ | |||
| // SPDX-FileCopyrightText: 2024 - 2025 The Ginkgo authors | |||
There was a problem hiding this comment.
I think the range of years is somehow incorrect ? I think it should 2017 - 2025 ? Or is it different for each file ?
There was a problem hiding this comment.
IMO it's not important that every file has the copyright 2017-2025. This file didn't exist 2017, so putting a copyright for that year into it seems a bit pointless. Also this is just what the reuse tool does, so we should stick to it.
There was a problem hiding this comment.
Yes, I think that is fine, but neighborhood_communicator.cpp also didnt exist in 2017. So, I would prefer that we be uniform.
There was a problem hiding this comment.
TBH, I will not change the copyright header that is added by our tooling. I think the reason for the difference is that the file with 2017-2025 was created when we still had our custom format_header.sh, which always put in the 2017. New files created from now on will not have the 2017 anymore.
| @@ -0,0 +1,273 @@ | |||
| // SPDX-FileCopyrightText: 2017 - 2025 The Ginkgo authors | |||
MarcelKoch
added
1:ST:ready-to-merge
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
2 times, most recently
from
a1b5990 to
37f5bba
Compare
Signed-off-by: Marcel Koch <[email protected]>
Signed-off-by: Marcel Koch <[email protected]>
Signed-off-by: Marcel Koch <[email protected]>
Co-authored-by: Pratik Nayak <[email protected]> Signed-off-by: Marcel Koch <[email protected]>
Signed-off-by: Marcel Koch <[email protected]>
Co-authored-by: Pratik Nayak <[email protected]> Signed-off-by: Marcel Koch <[email protected]>
Signed-off-by: Marcel Koch <[email protected]>
- fix include guards - update docs - implement copy/move constructors/assignment with tests - add equality test for collective communicators (needed for testing) - always enable neighborhood comm, just throw if openmpi is too old - define moved-from state as MPI_COMM_NULL + empty sizes/offsets - remove unnecessary namespace - make virtual function protected Co-authored-by: Pratik Nayak <[email protected]> Co-authored-by: Tobias Ribizel <[email protected]> Signed-off-by: Marcel Koch <[email protected]>
- documentation - formatting - refactor test - fix docs - merge tests Co-authored-by: Yu-Hsiang M. Tsai <[email protected]> Signed-off-by: Marcel Koch <[email protected]>
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
37f5bba to
d7d3d40
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1780 +/- ##
===========================================
- Coverage 89.31% 89.17% -0.15%
===========================================
Files 811 817 +6
Lines 67514 67816 +302
===========================================
+ Hits 60301 60474 +173
- Misses 7213 7342 +129 ☔ View full report in Codecov by Sentry. |
|
A note on the reported test coverage: the neighborhood communicator is completely missing, because the CI image uses an old open mpi version, for which the neighborhood implementation is deactivated. |
This is just #1588, which was marked as merged, because I reordered some commits, and GH interpreted this as the
neighborhood-communicatorbranch being merged.For comments and details, see the previous PR.