feat(analytics) : Ajout d'une sous-application analytics #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the base DBT skeleton, as created by the "dbt init" command. We'll then modify it incrementally, to keep the reader aware of the changes.
We'll change them incrementally as well.
TODO: - reference sources correctly through a YML - declare the index correctly in a _models.yml
Timed at 4 minutes an execution at the time of writing.
laurinehu
reviewed
Jan 8, 2025
|
|
||
| final AS ( | ||
| SELECT * FROM orientations | ||
| WHERE CAST(creation_date AS DATE) >= '2024-07-01' |
There was a problem hiding this comment.
ça me paraît un peu fort quand même ces conditions temporelles, ça sort d'où 07/2024 ?
perso je mettrais rien pour ne pas être bloqués si on veut par exemple comparer l'évolution mensuelle d'une année à une autre ?
Comment on lines
+11
to
+21
| CASE | ||
| WHEN | ||
| src.modification_date + '240 days' <= NOW() | ||
| AND src.status = 'PUBLISHED' | ||
| THEN 'REQUIRED' | ||
| WHEN | ||
| src.modification_date + '180 days' <= NOW() | ||
| AND src.status = 'PUBLISHED' | ||
| THEN 'NEEDED' | ||
| ELSE 'NOT_NEEDED' | ||
| END AS update_status |
There was a problem hiding this comment.
ça me semble utile un petit comm pour expliquer ça, non ?
| final AS ( | ||
| SELECT | ||
| services.*, | ||
| CONCAT('https://dora.inclusion.beta.gouv.fr/services/', services.slug) AS dora_url |
There was a problem hiding this comment.
c'est peut-être overkill mais je l'ai vu passer deux fois et j'adore les macros donc je me demandais s'il n'était pas opportun d'en faire une petite 0:)
{% macro dora_url(resource, slug) %}
CONCAT('https://dora.inclusion.beta.gouv.fr/', resource, '/', slug)
{% endmacro %}
dora_url("services", services.slug) as dora_url
en l'écrivant je me dis qu'on perd peut-être en lisibilité dans le code (mais j'aime trop les macros donc je laisse la proposition)
| CONCAT('https://dora.inclusion.beta.gouv.fr/structures/', slug) AS dora_url | ||
| FROM src | ||
| structures.*, | ||
| CONCAT('https://dora.inclusion.beta.gouv.fr/structures/', structures.slug) AS dora_url |
There was a problem hiding this comment.
et du coup
dora_url("structures", structures.slug) as dora_url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Les commits sont découpés pour aider à la compréhension.
L'idée est de passer doucement d'un modèle avec des scripts SQL non managés dans dora-back, à:
dora-analytics, avec sa propre base PostgreSQL)dora-back-proddora-analytics, avec le SSO Google et des permissions strictesLes deux Metabase peuvent coexister en attendant, de même que les scripts de synchronisation actuels.
Les questions et dashboards les plus utiles seront à porter individuellement dans le nouveau Metabase en faisant attention aux bonnes pratiques Metabase , cc @laurinehu .