#2776 #2778 - envoyer les mails de relances du bilan #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Review app: |
JeromeBu
reviewed
Jan 20, 2025
back/src/domains/convention/adapters/InMemoryConventionRepository.ts
Outdated
Show resolved
Hide resolved
celineung
force-pushed
the
2776-bilan-mvp-etq-prescripteur-je-souhaite-suivre-la-complétion-du-bilan-24
branch
from
e94e730 to
69b5d39
Compare
celineung
force-pushed
the
2776-bilan-mvp-etq-prescripteur-je-souhaite-suivre-la-complétion-du-bilan-24
branch
from
69b5d39 to
3319fe4
Compare
JeromeBu
reviewed
Jan 20, 2025
Comment on lines
60
to
61
| await Promise.all([ | ||
| executeInSequence(conventionIdsToRemind, async (conventionId) => { |
There was a problem hiding this comment.
il me semble que execute in sequence renvoie une seule promise, donc tu peux juste faire ça :
Suggested change
| await Promise.all([ | |
| executeInSequence(conventionIdsToRemind, async (conventionId) => { | |
| await executeInSequence(conventionIdsToRemind, async (conventionId) => { |
JeromeBu
approved these changes
Jan 20, 2025
celineung
force-pushed
the
2776-bilan-mvp-etq-prescripteur-je-souhaite-suivre-la-complétion-du-bilan-24
branch
from
3319fe4 to
162f696
Compare
celineung
force-pushed
the
2776-bilan-mvp-etq-prescripteur-je-souhaite-suivre-la-complétion-du-bilan-24
branch
from
162f696 to
98a67c4
Compare
celineung
deleted the
2776-bilan-mvp-etq-prescripteur-je-souhaite-suivre-la-complétion-du-bilan-24
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.