Skip to content

Commit

Permalink
Simplify update_admin_role with get_object_or_404
Browse files Browse the repository at this point in the history
If the membership to update cannot be found, use the standard status
code 404. Also allows using django shortcuts.
  • Loading branch information
francoisfreitag committed Feb 3, 2025
1 parent 7ca047f commit ec010c5
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions itou/common_apps/organizations/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"""

from django.contrib import messages
from django.core.exceptions import ObjectDoesNotExist, PermissionDenied
from django.core.exceptions import PermissionDenied
from django.http import HttpResponseRedirect
from django.shortcuts import get_object_or_404, render

Expand Down Expand Up @@ -37,13 +37,11 @@ def update_org_admin_role(request, target_member, action):
if not request.is_current_organization_admin or target_member == request.user:
raise PermissionDenied

try:
membership = request.current_organization.memberships.select_related("user").get(
user=target_member,
is_active=True,
)
except ObjectDoesNotExist:
raise PermissionDenied
membership = get_object_or_404(
request.current_organization.memberships.select_related("user"),
user_id=target_member.pk,
is_active=True,
)

if request.method == "POST":
match action:
Expand Down

0 comments on commit ec010c5

Please sign in to comment.