Employeur: Réduction de la durée de validité du diagnostic d’éligibilité à 92 jours [GEN-2276] #5285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of falling back to the save method, directly specify the expiration date. That change facilitates an upcoming feature where the diagnosis validity period will be based on the author kind. The tests were expecting a validity of 6 months after creation. The eligibility factories now handle that.
Instead of merging dicts, set the keys directly. That’s clearer and faster. Also, it will help conditionally inserting an entry later.
Employers must be able to justify administrative criteria they selected for an IAE hire. The proof is valid for 3 months (we decided 92 days). Matching the eligibility duration to proof validity period has avoids a number of edge cases, such has a hire that starts in 5 months with an RSA criteria: the employer does not have a proof that the candidate will still be eligible in 2 months. With administrative criteria being certified, the certification period now matches the eligibility diagnosis duration. The `hiring_start_at` remains unchecked, because the subject is pretty complex. Tracked with https://www.notion.so/plateforme-inclusion/S-assurer-que-les-dates-d-embauche-en-SIAE-correspondent-une-p-riode-de-validit-du-diagnostic-158e8fa5c35b80959d71c3642d33512e
francoisfreitag
changed the title
francoisfreitag
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
celine-m-s
reviewed
Dec 18, 2024
| @@ -2879,6 +2886,7 @@ def test_hire_as_company(self, client): | |||
| assertTemplateUsed(response, "approvals/includes/box.html") | |||
| assert response.status_code == 200 | |||
|
|
|||
| @freeze_time() | |||
There was a problem hiding this comment.
Pourquoi ces yeux ?
There was a problem hiding this comment.
Ah pardon, j'ai cru que c'étaient des oublis. Je me demandais pourquoi utiliser freeze_time sans passer de date en paramètre. Je n'ai rien vu dans la doc à ce sujet.
There was a problem hiding this comment.
Nope, c’est voulu parce que je hardcode la date attendue (à +92j). C’est pour éviter des échecs autour de minuit.
celine-m-s
approved these changes
Dec 18, 2024
xavfernandez
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Aligner la durée de validité des diagnostics employeur avec la durée de validité des justificatifs (3 mois).
🏝️ Comment tester
Vérifier que les diagnostics IAE PH et GEIQ continuent de durer 6 mois.
💻 Captures d'écran