Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utiliser une socket UNIX pour se connecter à la base de données en dev #5455

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Utiliser une socket UNIX pour se connecter à la base de données en dev #5455

merged 1 commit into from
Jan 30, 2025

Conversation

francoisfreitag
Copy link
Contributor

@francoisfreitag francoisfreitag commented Jan 24, 2025 •
edited
Loading

TCP has a measurable overhead for each DB query compared to the unix
socket.
https://momjian.us/main/blogs/pgblog/2012.html#June_6_2012

@francoisfreitag francoisfreitag added the no-changelog Ne doit pas figurer dans le journal des changements. label Jan 24, 2025
@francoisfreitag francoisfreitag self-assigned this Jan 24, 2025
@francoisfreitag francoisfreitag force-pushed the ff/socket branch 5 times, most recently from 9ae8fe5 to 3e66110 Compare January 24, 2025 08:41
@francoisfreitag
Use a socket connection to the database in dev
ac6d8c9 
TCP has a measurable overhead for each DB query compared to the unix
socket.
https://momjian.us/main/blogs/pgblog/2012.html#June_6_2012
@francoisfreitag
Copy link
Contributor Author

On gagne en général une minute par rapport aux builds CI des dernières PRs:

@tonial
Copy link
Contributor

tonial commented Jan 24, 2025

Cool !

@tonial
Copy link
Contributor

tonial commented Jan 24, 2025

Je note la technique pour attirer notre attention sur cette PR grace aux mentions 👍

xavfernandez
xavfernandez approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je passe de 2min43s à 2min40s en local, je suis conquis 😜

Mais ça marche tout aussi bien et consomme moins de ressources 👍

leo-naeka
leo-naeka approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@leo-naeka leo-naeka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tourne parfaitement sous macOS également.
Navré d'imposer la socket au sein du projet et de ne pas pouvoir utiliser XDG_RUNTIME_DIR 🤗

Tout comme Xavier, le gain en local est anecdotique mais c'est vraiment top en CI 👏

@francoisfreitag francoisfreitag added this pull request to the merge queue Jan 30, 2025
Merged via the queue into master with commit 7e8268b Jan 30, 2025
9 checks passed
@francoisfreitag francoisfreitag deleted the ff/socket branch January 30, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwenKorr EwenKorr EwenKorr approved these changes

@rsebille rsebille rsebille approved these changes

@xavfernandez xavfernandez xavfernandez approved these changes

@leo-naeka leo-naeka leo-naeka approved these changes

@celine-m-s celine-m-s Awaiting requested review from celine-m-s

@calummackervoy calummackervoy Awaiting requested review from calummackervoy

@dejafait dejafait Awaiting requested review from dejafait

@vincentporte vincentporte Awaiting requested review from vincentporte

Assignees

@francoisfreitag francoisfreitag

Labels
no-changelog Ne doit pas figurer dans le journal des changements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@francoisfreitag @tonial @leo-naeka @xavfernandez @rsebille @EwenKorr