some OVN NB Table's Name field is a pointer type since its optional

nil string pointer wasn't properly checked while determining whether it had empty value Signed-off-by: Girish Moodalbail <[email protected]>
girishmg · Feb 8, 2022 · 84b0d46 · 84b0d46
1 parent 0eb68cf
commit 84b0d46
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/go-controller/pkg/libovsdbops/model_client.go b/go-controller/pkg/libovsdbops/model_client.go
@@ -302,9 +302,19 @@ func (m *ModelClient) create(opModel *OperationModel) ([]ovsdb.Operation, error)
 		})
 	} else if info, err := m.client.Cache().DatabaseModel().NewModelInfo(opModel.Model); err == nil {
 		if name, err := info.FieldByColumn("name"); err == nil {
-			if len(fmt.Sprint(name)) > 0 {
+			var objName string
+			var ok bool
+			if objName, ok = name.(string); !ok {
+				if strPtr, ok := name.(*string); ok {
+					if strPtr != nil {
+						objName = *strPtr
+					}
+				}
+			}
+			if len(objName) > 0 {
 				klog.Warningf("OVSDB Create operation detected without setting opModel Name. Name: %s, %#v",
-					name, info)
+					objName, info)
+
 			}
 		}
 	}