Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid segfault when freeing parse #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atoomic
Copy link

@atoomic atoomic commented Aug 24, 2020

RT-115034

Protect active parser from being freed

URL: https://rt.cpan.org/Public/Bug/Display.html?id=115034
Author: sprout

t/free.t Outdated
use Test::More tests => 1;

use HTML::Parser;
$p = new HTML::Parser(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use indirect object notation or -w

#!perl
use strict;
use warnings;
use HTML::Parser ();
use Test::More tests => 1;

my $p = HTML::Parser->new( ...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both fixed, I blindly copy/paste the test from sprout :-)
I've enforce strict/warnings

RT-115034

Protect active parser from being freed

URL: https://rt.cpan.org/Public/Bug/Display.html?id=115034
Author: sprout
@genio
Copy link

genio commented Aug 24, 2020

@atoomic Thank you! I'll work on getting this moved over to the LWP org today and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants