Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to eslint flat config #4113

Merged
merged 6 commits into from
Jun 18, 2024
Merged

feat: migrate to eslint flat config #4113

merged 6 commits into from
Jun 18, 2024

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Jun 18, 2024 •
edited
Loading

Changes

  • Bumped eslint to latest (9.5.0)
  • Migrated config

Todos

  • It complains the Svelte 5 rune globals are undefined in a few spots
    • Manually added them to globals for now
    • Asked about it in the eslint-plugin-svelte repo and issue here

Caleb-T-Owens
Caleb-T-Owens approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@Caleb-T-Owens Caleb-T-Owens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ndom91 ndom91 marked this pull request as ready for review June 18, 2024 16:18
@ndom91 ndom91 merged commit 76956bd into master Jun 18, 2024
15 checks passed
@ndom91 ndom91 deleted the ndom91/eslint-plugin-svelte-latest branch June 18, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caleb-T-Owens Caleb-T-Owens Caleb-T-Owens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndom91 @Caleb-T-Owens