Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payouts for individual projects #2763

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Fix payouts for individual projects #2763

merged 2 commits into from
Jan 10, 2024

Conversation

boudra
Copy link
Contributor

@boudra boudra commented Dec 22, 2023

Fixes: #issue

Description

payouts fail when paying any projects after paying one because the merkle root is different

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 5:04pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 5:04pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 5:04pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 5:04pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 5:04pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 5:04pm

Copy link

gitstream-cm bot commented Dec 22, 2023

This PR is 61.111111111111114% new code.

Copy link

gitstream-cm bot commented Jan 2, 2024

🥷 Code experts: vacekj, bhargavaparoksham

vacekj, bhargavaparoksham have most 👩‍💻 activity in the files.
vacekj has most 🧠 knowledge in the files.

See details

packages/round-manager/src/features/api/payoutStrategy/payoutStrategy.ts

Activity based on git-commit:

vacekj bhargavaparoksham
JAN
DEC
NOV
OCT 285 additions & 0 deletions
SEP
AUG

Knowledge based on git-blame:
vacekj: 6%

packages/round-manager/src/features/round/ViewFundGrantees.tsx

Activity based on git-commit:

vacekj bhargavaparoksham
JAN
DEC 2 additions & 1 deletions
NOV 0 additions & 3 deletions
OCT 47 additions & 48 deletions
SEP
AUG

Knowledge based on git-blame:
vacekj: 16%

packages/round-manager/src/features/round/__tests__/ViewFundGrantees.test.tsx

Activity based on git-commit:

vacekj bhargavaparoksham
JAN
DEC
NOV
OCT 3 additions & 1 deletions
SEP 22 additions & 0 deletions
AUG

Knowledge based on git-blame:
vacekj: 28%

To learn more about /:\ gitStream - Visit our Docs

@michellema1208 michellema1208 linked an issue Jan 2, 2024 that may be closed by this pull request
@boudra boudra merged commit 043cfb2 into main Jan 10, 2024
14 checks passed
@boudra boudra deleted the fix/payouts branch January 10, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix payouts for individual projects
2 participants