Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic handling of fees and proxy attestations implementation #3687

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

nijoe1
Copy link
Member

@nijoe1 nijoe1 commented Oct 14, 2024

Improves

  • Attestations fee handling
  • No funds error handling
  • Distinguishes proxy delegation requests with delegation requests

@nijoe1 nijoe1 requested review from a team as code owners October 14, 2024 20:25
Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 8:29pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 8:29pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 8:29pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 8:29pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 8:29pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 8:29pm

Copy link
Member

@hussedev hussedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelostone-mc thelostone-mc merged commit 288bc27 into gg-22 Oct 15, 2024
13 of 14 checks passed
@thelostone-mc thelostone-mc deleted the fix/gg22-dynamicFeeAndProxyHandling branch October 15, 2024 05:52
thelostone-mc added a commit that referenced this pull request Oct 16, 2024
* feat: add bridging widget to checkout (#3645)

---------

Co-authored-by: 0xKurt <[email protected]>

* chore: redo donation history page (#3666)


Co-authored-by: Aditya Anand M C <[email protected]>

* feat: add mint attestation to thank you page (#3662)

* added mint attestation workflow in donation history page and code ref… (#3671)

* added mint attestation workflow in donation history page and code refactoring

* workflow improvements

* refactored attestation mint modal

* chore: check transaction minting in history page (#3676)

* feat: implemented data-layer attestationService

* chore: implemented useMintingAttestations

* chore: renamed useContributionHistory to useContributionsByDonor

* refactor: useContributionsByDonor now uses useQuery

* chore: useMintingAttestations export type and add default parameter

* chore: changed MintDonationButtonProps

* chore: check if transaction is minted - propDrilling

* fix: data-layer attestation types

* chore: moved ImageWithLoading to common feature

* fix: DonationsTransactions - missing key in rendering map

* chore: AttestationService - added metadata and timestamp to query

* chore: useMintingAttestations sort response by timestamp desc

* fix: MintingAttestationIdsData - metadata is array

* chore: remove MintDonationButton from MintDonationImapactAction

* chore: implemented modal and used it to display MintingImage

* Update packages/builder/src/components/grants/rounds/LinkManager.tsx

* bump : squid widget (#3677)

* bump : squid widget

* fix

* remove unused coe

* Gg22 thank you page improvs (#3679)

* seperated checkoutStore with attestation store

* getting round names for attestation frame for thank you page

* allow minting below 20 attestation has no fee (#3678)

* add zero fee attestation

* free mint when totalAttestation < threshold

* chore: view attestation modal design (#3681)

* chore: added close icon

* chore: added responsiveness to TransactionHeader

* chore: implemented RainbowBorderButton

* chore: implemented ViewTransactionButton

* refactor: MindDonationButton renders RainbowBorderButton

* chore: implemented ViewAttestationModal

* chore: refactored Modal

* chore: use ViewAttestationModal in MintingActionButtons

* chore: added go to attestation transaction page functionality

* improved attestation frame made it more dynamic-minimal (#3682)

* improved attestation frame made it more dynamic-minimal

* make sure the frame projects images are fetched

* dynamic handling of fees and proxy attestations implementation (#3687)

* adds twitter sharable urls

* fix: update encoding and format for farcaster share URLs

* chore: make bridge button more prominent

close PAR-530

* - revese ui on thank you page mobile screen
- add border to twitter button

close PAR-531
close PAR-528

* fix title

---------

Co-authored-by: 0xKurt <[email protected]>
Co-authored-by: Huss Martinez <[email protected]>
Co-authored-by: Nick Lionis <[email protected]>
Co-authored-by: Nick Lionis <[email protected]>
Co-authored-by: veganbeef <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants