Add Noir

[critesjosh]

Description

Adding the Noir programming language.

Checklist:

• I am adding a new language.
  • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • Search results for each extension:
      • https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.nr+%2F%5E%5Cs*fn%5B+%5Ct%5D%2B%5B%5E%5C%28%5Cs%5D.*%3F%5C%28%2F+NOT+user%3AAztecProtocol+NOT+user%3Anoir-lang
  • I have included a real-world usage sample for all extensions added in this PR:
    • Sample source(s):
      • array.nr MIT/APACHE
      • voting.nr MIT
      • roff1.nr - license in comments
      • roff.nr - copyright
  • I have included a syntax highlighting grammar: https://github.com/noir-lang/vscode-noir
  • I have added a color
    • Hex value: #2f1f49
    • Rationale: This color is used in the Noir branding color palate.
  • I have updated the heuristics to distinguish my language from others using the same extension.

[critesjosh]

I'm not sure what is going on with Github search, but there are fewer files found today than yesterday. There should be more--I pushed a public repo and I know for a fact at least 3 other people did as well.

[critesjosh]

@lildude Do you need anything else from me on this?

I am wondering how to best track popularity. When I first drafted this search query, there were 376 files. Now its only showing 358. I know more people have been pushing public repos, so it doesn't seem to be picking up on them for some reason.

[lildude]

I think you might have put the samples/Noir/roff.nr sample in the wrong directory or accidentally added it as it looks more like Roff than Noir to my naïve eye.

The same applies for the samples/Noir/roff1.nr sample which is also massive and waaay bigger than we need. ProTip: if the diff suppresses the content, the file is too big.

[lildude]

I am wondering how to best track popularity. When I first drafted this search query, there were 376 files. Now its only showing 358. I know more people have been pushing public repos, so it doesn't seem to be picking up on them for some reason.

There's only search, which is expected to fluctuate as people add and remove repos and files. This is only really noticeable as there are so few files. When things reach close to our requirements, a deviation of 18 files is trivial and not really an issue.

[critesjosh]

I think you might have put the samples/Noir/roff.nr sample in the wrong directory or accidentally added it as it looks more like Roff than Noir to my naïve eye.

The same applies for the samples/Noir/roff1.nr sample which is also massive and waaay bigger than we need. ProTip: if the diff suppresses the content, the file is too big.

Do you need examples of Roff, since it has the same extension as Noir? Should I add them to samples/Roff/roff.nr? Or since there is already a samples/Roff/trekmanual.nr, can I delete them?

[critesjosh]

I am wondering how to best track popularity. When I first drafted this search query, there were 376 files. Now its only showing 358. I know more people have been pushing public repos, so it doesn't seem to be picking up on them for some reason.

There's only search, which is expected to fluctuate as people add and remove repos and files. This is only really noticeable as there are so few files. When things reach close to our requirements, a deviation of 18 files is trivial and not really an issue.

Just curious, how do you assess when things reach close to your requirements, since the search doesn't return the number of repos?

[lildude]

Do you need examples of Roff, since it has the same extension as Noir? Should I add them to samples/Roff/roff.nr? Or since there is already a samples/Roff/trekmanual.nr, can I delete them?

Noir and Roff are very different so the classifier shouldn't have problems distinguishing between the two. That said, there's no harm adding one (the smaller) to the Roff samples directory. As we'll then have two for each language, the "Classifier cross-validation (pull_request)" test will then start to test the classifier for the .nr extension.

Just curious, how do you assess when things reach close to your requirements, since the search doesn't return the number of repos?

See #5756 (this is referenced in the docs too). I'm slowly reassessing this now the new search is open for all and we can get better results. When I've come up with a good reliable strategy, I'll update the docs and close that issue.

[critesjosh]

Thanks for your help with this! Let me know if I need to make any more updates.

[TomAFrench]

The submodule could probably do with a bump btw @critesjosh. We've made some changes to the highlighting recently.

[signorecello]

@lildude how are we doing with this integration? There are more and more people exploring zero-knowledge proofs so it would be really cool to have support 😊

[lildude]

Still got failing tests. Run this cmd to fix. I'll re-evaluate popularity when I come to make the next release which will in the next two weeks, assuming the failures have been addressed by then.

[critesjosh]

Thanks! Just ran the command and pushed changes

[lildude]

Things don't look popular enough once we exclude the AztecProtocol user that is responsible for nearly 650 of the found files.

[critesjosh]

Huh, I only see a difference of ~200 files (1.9k vs 1.7k), but I guess we can wait a few more weeks. 🙂

[signorecello]

Hitting 1.8k again, when is a new release planned @lildude ?

[lildude]

Same as usual... approx 3-4 months after the last one.

[Savio-Sou]

1.8k now (with both AztecProtocol and noir-lang excluded):

Requested changes applied. Pending popularity now.

[Savio-Sou]

2.1k 🚀 @lildude curious if that's sufficient popularity?

[aguzmant103]

@lildude I vouch this PR as a user :)
(don't know if it makes a difference but would appreciate this, lol)

[Savio-Sou]

@lildude / @Alhadis wonder if we're all set to remove the Pending Popularity label + resolve pending reviews?

[Alhadis]

LGTM. 👍

[Savio-Sou]

Thanks! @lildude would be grateful for your re-review.

[Savio-Sou]

Thank you all on behalf of the Noir community for the help along the way ❤️