Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .vyi to allowed Vyper extensions #6792

Closed

Conversation

charles-cooper
Copy link

@charles-cooper charles-cooper commented Apr 12, 2024

Description

vyper 0.4.0 adds .vyi files for defining standalone interfaces (see vyperlang/vyper@c6f457a / vyperlang/vyper#3663).

Checklist:

potential distinguishing syntax (if necessary): def, event, struct and # for comments

vyper 0.4.0 adds `.vyi` files for defining standalone interfaces.
@charles-cooper charles-cooper requested a review from a team as a code owner April 12, 2024 14:05
@lildude
Copy link
Member

lildude commented Apr 12, 2024

I'm closing this PR as it is waaaay too early to submit it. There are only 17 files indexed on GitHub and they're owned by two users. This is a long long long way from meeting our requirements. Feel free to open a new PR once usage has met our requirements, and as a tip, when you do, include a sample file with the extension too 😉

@lildude lildude closed this Apr 12, 2024
@charles-cooper
Copy link
Author

what do you mean, "include a sample file with the extension"? that's part of the PR description

@lildude
Copy link
Member

lildude commented Apr 12, 2024

We need the file added to the PR itself in the relevant directory under samples/. It's used to train the classifier which only reads the content of the samples/ directory. This is documented.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants