Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options param to listIssueComments to get pagination result #399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bambooom
Copy link

as I found that _requestAllPages will be deprecated, so I just add options to _request method to solve the problem I met in #398. 😊

@metaodi
Copy link

metaodi commented Jun 20, 2017

To have an options parameter is great, this would make it possible to pass the since parameter, to only get a subset of all comments.

@j-rewerts j-rewerts mentioned this pull request Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants