Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add collaborator #462

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add ability to add collaborator #462

wants to merge 6 commits into from

Conversation

mtscout6
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 17, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@22b889c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #462   +/-   ##
=========================================
  Coverage          ?   91.11%           
=========================================
  Files             ?       12           
  Lines             ?      405           
  Branches          ?        0           
=========================================
  Hits              ?      369           
  Misses            ?       36           
  Partials          ?        0
Impacted Files Coverage Δ
lib/Team.js 100% <ø> (ø)
lib/Requestable.js 94.17% <100%> (ø)
lib/Repository.js 80.83% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22b889c...c5c3060. Read the comment docs.

@@ -1,9 +1,8 @@
sudo: false
language: node_js
node_js:
- '8'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I opened PR #468 to to test against Node.js v8, which can be closed if this is merged.

@j-rewerts
Copy link
Member

It seems like this API was considered preview? Newer docs have the URL being /repos/:owner/:repo/collaborators/:username, which is the same as the one that was used, so that's nice!

This PR would be easier to review if it didn't also switch the CI and add async await. @clayreimann Is there any plans to change which versions of Node this library builds for? I'm thinking we could merge in the addCollaborator stuff and leave async await for another day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants