Rename feature flag for evaluator fine-grained parallelism #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
previously approved these changes
Oct 11, 2023
nickrolfe
force-pushed
the
nickrolfe/rename_fgp_flag
branch
from
2238d33 to
06d8f4f
Compare
|
Marking ready for review, since we've now reached sufficient confidence in the feature to begin rolling it out for 2.15.1 onwards. |
henrymercer
approved these changes
Oct 26, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the implementation of fine-grained parallelism in 2.14.x, making it unsafe to enable the feature flag. By renaming the feature flag, we can safely enable it without turning the feature on for people using 2.14.x and old versions of the Action.
Merge / deployment checklist