Minor cleanup #2580
Minor cleanup #2580
Conversation
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
This allows runners that don't have the cache to run these workflows.
| permissions: | ||
| contents: read | ||
| security-events: write |
There was a problem hiding this comment.
Is this necessary? CODEQL_ACTION_TEST_MODE should prevent the sarif from being uploaded.
Maybe this is all that is necessary (in order to check out the repo):
permissions:
contents: read
There was a problem hiding this comment.
Expected Queries Tests
This run of the CodeQL Action does not have permission to access Code Scanning API endpoints. As a result, it will not be opted into any experimental features. This could be because the Action is running on a pull request from a fork. If not, please ensure the Action has the 'security-events: write' permission. Details: Resource not accessible by integration
https://github.com/check-spelling-sandbox/github-codeql-action/actions/runs/11648653925
There was a problem hiding this comment.
This is probably something about running in a fork. It's not a problem to leave it in.
| @@ -16,7 +16,9 @@ steps: | |||
| const fs = require('fs'); | |||
| const path = require('path'); | |||
| const codeqlPath = path.join(process.env['RUNNER_TOOL_CACHE'], 'CodeQL'); | |||
| fs.rmdirSync(codeqlPath, { recursive: true }); | |||
| if (codeqlPath !== undefined) { | |||
There was a problem hiding this comment.
Can you explain why you need this? Is this because you are using a self-hosted runner somewhere?
There was a problem hiding this comment.
I'm using nektos/act which uses a custom image
There was a problem hiding this comment.
I've also historically used self-hosted runners.
| @@ -16,7 +16,9 @@ steps: | |||
| const fs = require('fs'); | |||
| const path = require('path'); | |||
| const codeqlPath = path.join(process.env['RUNNER_TOOL_CACHE'], 'CodeQL'); | |||
| fs.rmdirSync(codeqlPath, { recursive: true }); | |||
| if (codeqlPath !== undefined) { | |||
| permissions: | ||
| contents: read | ||
| security-events: write |
There was a problem hiding this comment.
This is probably something about running in a fork. It's not a problem to leave it in.
Merge / deployment checklist