Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Git subgraph fetching for diff-informed queries #2638

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Improve Git subgraph fetching for diff-informed queries #2638

merged 5 commits into from
Dec 10, 2024
+104 −22

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Dec 9, 2024

This PR improves how the action fetches the relevant Git subgraph used for computing the merge base with the base branch.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

cklin added 5 commits December 9, 2024 10:46
@cklin
Introduce withGroupAsync()
70aac4e
@cklin
deepenGitHistory: specify HEAD
dd4aa40 
This commit makes deepenGitHistory pass "origin HEAD" to Git fetch,
which prevents Git from fetching all branches that are present in the
remote repository.
@cklin
deepenGitHistory: do not fetch submodules
3e10d34
@cklin
getPullRequestEditedDiffRanges: work around fatal error
57a2859 
This commits adds a "git repack" step to getPullRequestEditedDiffRanges
to work around a Git bug concerning tracking of grafted commits.
@cklin
build: refresh js files
f9b0c1f
@cklin cklin marked this pull request as ready for review December 9, 2024 19:02
@cklin cklin requested a review from a team as a code owner December 9, 2024 19:02
henrymercer
henrymercer approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks sensible to me, assuming you've done the necessary manual testing. I'd like to see us add a PR check so we can validate this behaviour end to end, but that can be future work.

@cklin cklin merged commit dfed55c into main Dec 10, 2024
522 checks passed
@cklin cklin deleted the cklin/diff-informed-graph-fetching-tweak branch December 10, 2024 16:42
This was referenced Dec 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cklin @henrymercer