Shared: Use edge dominance terminology in basic block library #18696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paldepind
force-pushed
the
shared-bb-dominates
branch
from
56cac75 to
820d2cb
Compare
There was a problem hiding this comment.
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
|
I have started DCA runs. |
hvitved
requested changes
Feb 11, 2025
Co-authored-by: Tom Hvitved <[email protected]>
hvitved
previously approved these changes
Feb 11, 2025
aschackmull
reviewed
Feb 11, 2025
aschackmull
reviewed
Feb 11, 2025
Comment on lines
180
to
181
| * can only be reached through `bb` and dominated by an _edge_ `s` if it can | ||
| * only be reached through `s`. |
aschackmull
reviewed
Feb 11, 2025
Comment on lines
180
to
181
| * it can only be reached through `bb` and dominated by an _edge_ `s` if it | ||
| * can only be reached through `s`. |
aschackmull
reviewed
Feb 11, 2025
aschackmull
reviewed
Feb 11, 2025
aschackmull
reviewed
Feb 11, 2025
aschackmull
reviewed
Feb 11, 2025
Co-authored-by: Anders Schack-Mulligen <[email protected]>
|
Thanks for the reviews. Comments should be addressed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #18497.
This PR changes the shared basic block library to use the term "edge dominance" instead of "control". A key benefit of doing this is that "edge dominance" should be intuitive to those familiar with the standard notion of dominance in control flow graphs.
immediatelyControls/3is nowdominatingEdge/2. I've dropped an argument since the last two contain the same amount of information. I wasn't quite sure whether to drop the basic block or the successor type, but ended up keeping the later for consistency with Java. It's also no longer a member predicate since it's not related to any of it's two arguments more than the other.controlsis nowedgeDominates, but is otherwise unchanged.ConditionBlockclasses I've added deprecations. These libraries are not re-exportingdominatingEdgebecause 1/ The existingimmediatelyControlsseems unused (I'm guessing it's key job is as a building block forcontrol/edgeDominatesand 2/edgeDominatescan subsume it.Todo