Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license; remove redundant Go qlpack license. #18699

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Feb 6, 2025

No description provided.

@Copilot Copilot bot review requested due to automatic review settings February 6, 2025 10:24
@smowton smowton requested review from a team as code owners February 6, 2025 10:24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@github-actions github-actions bot added the Go label Feb 6, 2025
owen-mc
owen-mc previously approved these changes Feb 6, 2025
@owen-mc owen-mc dismissed their stale review February 6, 2025 11:00

Oh wait, the tests really did not like you removing the license

@smowton
Copy link
Contributor Author

smowton commented Feb 6, 2025

Had a go at fixing it

Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth getting someone who is more familiar with Bazel to have a look before merging?

@smowton smowton merged commit fe34aa3 into main Feb 20, 2025
12 checks passed
@smowton smowton deleted the smowton/admin/update-license branch February 20, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants