Merge pull request #32742 from github/repo-sync

Repo sync
github · Apr 30, 2024 · f22c57c · f22c57c
2 parents 7719c80 + 0d31da2
commit f22c57c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/content-render/unified/replace-domain.js b/src/content-render/unified/replace-domain.js
@@ -22,7 +22,6 @@ export default function alerts() {
   return (tree) => {
     visit(tree, matcher, (node) => {
       const code = node.children[0].children[0].value
-      let found = false
       for (const [regex, replacement] of VALID_REPLACEMENTS) {
         if (regex.test(code)) {
           const codeTag = node.children[0]
@@ -31,13 +30,8 @@ export default function alerts() {
             replacements.push(replacement)
             codeTag.properties['data-replacedomain'] = replacements
           }
-          found = true
         }
       }
-
-      if (!found && process.env.NODE_ENV === 'development') {
-        console.warn("The code snippet doesn't contain a valid replacement", { code })
-      }
     })
   }
 }
diff --git a/src/fixtures/fixtures/content/get-started/markdown/replace-domain.md b/src/fixtures/fixtures/content/get-started/markdown/replace-domain.md
@@ -38,3 +38,12 @@ await fetch("https://HOSTNAME/api/v1")
 ```js
 await fetch("https://HOSTNAME/api/v2")
 ```
+
+## Not always there
+
+In this next code snippet, the `HOSTNAME` only appears if the current
+version is `ghes`. That should be fine.
+
+```text replacedomain copy
+ssh handle@{% ifversion ghes %}HOSTNAME{% else %}github.com{% endif %}
+```