-
Notifications
You must be signed in to change notification settings - Fork 60.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes Issue(31721): Added the link to What are your cookie choices and controls? #31733
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@code-Gambler Thanks so much for opening a PR! Looks great to me - I'm going to ask our Site Policy team to review ✨ Internal: asked here |
@code-Gambler Thanks again for opening this PR! I'll update the branch and get this merged once tests are passing 🍏 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why have you included the full URL, not just the fragment? |
I looked at other links, they had the whole URL, so I included the whole URL What do you guys suggest? Should I make a new PR with just the fragment? |
Should definitely just be the fragment as it's in the same file. |
Submitted a new pr with only the fragment! |
Why:
The link to What are your cookie choices and controls? was missing, so added the link in the
content/site-policy/privacy-policies/github-general-privacy-statement.md
fileCloses:
31721
What's being changed (if available, include any code snippets, screenshots, or gifs):
Only a link to this page is being added
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.