Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update removing-sensitive-data-from-a-repository.md #31760

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

diberry
Copy link
Contributor

@diberry diberry commented Feb 21, 2024

Add gitleaks as another way to prevent secrets leaks.

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Add gitleaks as another way to prevent secrets leaks.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 21, 2024
Copy link
Contributor

github-actions bot commented Feb 21, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/keeping-your-account-and-data-secure/removing-sensitive-data-from-a-repository.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Feb 21, 2024
@nguyenalex836
Copy link
Contributor

@diberry Thanks so much for opening a PR! I'll get this triaged for review ✨

Copy link
Contributor

@jc-clark jc-clark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion to add a preventative measure to this list @diberry!

After checking in with our team, we agreed that this information is good to include here, but we can't document the third-party gitleaks tool. I suggested changes for enabling push protections for the repository instead.

What do you think? If you commit the changes, I can help merge.

…moving-sensitive-data-from-a-repository.md

Co-authored-by: Joe Clark <[email protected]>
@mchammer01 mchammer01 dismissed jc-clark’s stale review March 22, 2024 18:35

docs updated as per @jc-clark's suggestion

Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM :shipit:

@nguyenalex836 nguyenalex836 enabled auto-merge March 22, 2024 18:39
@nguyenalex836 nguyenalex836 removed the waiting for review Issue/PR is waiting for a writer's review label Mar 22, 2024
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Mar 22, 2024
Merged via the queue into github:main with commit b5e1d50 Mar 22, 2024
39 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants